chaokunyang commented on code in PR #2898:
URL: https://github.com/apache/fory/pull/2898#discussion_r2494039732
##########
rust/fory-core/src/serializer/box_.rs:
##########
@@ -62,8 +61,8 @@ impl<T: Serializer + ForyDefault> Serializer for Box<T> {
}
#[inline(always)]
- fn fory_static_type_id() -> TypeId {
- T::fory_static_type_id()
+ fn fory_static_type_id(type_resolver: &TypeResolver) -> TypeId {
Review Comment:
`fory_static_type_id` method should be executed at compile time or optimized
by LLVM pass. We should not pass `type_resolver` in.
I even think we should make it as `const`, but currently stable rust doesn't
support that
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
