chaokunyang commented on code in PR #2914:
URL: https://github.com/apache/fory/pull/2914#discussion_r2529617443
##########
rust/fory-core/src/buffer.rs:
##########
@@ -179,7 +179,7 @@ impl<'a> Writer<'a> {
#[inline(always)]
pub fn write_sliint64(&mut self, value: i64) {
- if value >= HALF_MIN_INT && value <= HALF_MAX_INT {
+ if (HALF_MIN_INT..=HALF_MAX_INT).contains(&value) {
Review Comment:
Why use this range instead of conditional?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
