chaokunyang commented on code in PR #2999:
URL: https://github.com/apache/fory/pull/2999#discussion_r2596893255
##########
java/fory-core/src/main/java/org/apache/fory/serializer/collection/CollectionLikeSerializer.java:
##########
@@ -550,6 +552,21 @@ public void copyElements(Collection originCollection,
Object[] elements) {
}
}
+ public void copyElementsAddAll(Collection originCollection, Collection
newCollection) {
Review Comment:
This API is vague to me, and it should not be added as a public API of
CollectionLikeSerializer. And most serializer would never use it, why not just
create a private static method in CollectionSerializers with clear doc which
indicate why it's needed, and clarify it's only used by CopyOnWriteList/Set?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
