chaokunyang commented on code in PR #3060:
URL: https://github.com/apache/fory/pull/3060#discussion_r2629307413
##########
rust/fory-core/src/meta/type_meta.rs:
##########
@@ -372,15 +378,25 @@ impl TypeMeta {
}
#[inline(always)]
- pub fn empty() -> TypeMeta {
- TypeMeta {
+ pub fn get_bytes(&self) -> Vec<u8> {
Review Comment:
could we return borrowed ref and caller clone it instead? this will be more
explicit
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
