ariesdevil opened a new pull request, #3074: URL: https://github.com/apache/fory/pull/3074
…default <!-- **Thanks for contributing to Apache Fory™.** **If this is your first time opening a PR on fory, you can refer to [CONTRIBUTING.md](https://github.com/apache/fory/blob/main/CONTRIBUTING.md).** Contribution Checklist - The **Apache Fory™** community has requirements on the naming of pr titles. You can also find instructions in [CONTRIBUTING.md](https://github.com/apache/fory/blob/main/CONTRIBUTING.md). - Apache Fory™ has a strong focus on performance. If the PR you submit will have an impact on performance, please benchmark it first and provide the benchmark result here. --> ## Why? When using `#[derive(ForyObject)]` on a type that already has a manual `impl Default`, a compilation error occurs due to conflicting `Default` implementations. The previous behavior of auto-generating `Default` was problematic for integrating with existing codebases where types have custom `Default` implementations. After discussion with reviewers, we decided to **invert the default behavior**: `ForyObject` should NOT generate `impl Default` by default, and users who want it can opt-in with `#[fory(generate_default)]`. ## What does this PR do? ### Breaking Change `#[derive(ForyObject)]` **no longer generates `impl Default`** by default. ### Migration Guide ```rust // Before this PR (v0.14.0) #[derive(ForyObject)] struct MyStruct { ... } // Auto-generates Default // After this PR (v0.15.0) - Option 1: Add derive(Default) explicitly #[derive(ForyObject, Default)] struct MyStruct { ... } // After this PR (v0.15.0) - Option 2: Use generate_default attribute #[derive(ForyObject)] #[fory(generate_default)] struct MyStruct { ... } ``` ### Changes 1. Added `#[fory(generate_default)]` attribute to opt-in for `Default` generation 2. Changed all internal code generation to use `ForyDefault::fory_default()` instead of `Default::default()` 3. Updated `register_trait_type!` macro to use `ForyDefault` instead of `Default` 4. Updated documentation and tests 5. Used workspace dependencies for internal crate versions ## Related issues None ## Does this PR introduce any user-facing change? - [x] Does this PR introduce any public API change? - **Breaking**: `#[derive(ForyObject)]` no longer generates `impl Default` - **New**: `#[fory(generate_default)]` attribute to opt-in for `Default` generation - [ ] Does this PR introduce any binary protocol compatibility change? ## Benchmark This change only affects compile-time code generation. No runtime performance impact. <!-- When the PR has an impact on performance (if you don't know whether the PR will have an impact on performance, you can submit the PR first, and if it will have impact on performance, the code reviewer will explain it), be sure to attach a benchmark data here. Delete section if not applicable. --> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
