chaokunyang commented on code in PR #3076:
URL: https://github.com/apache/fory/pull/3076#discussion_r2643691859
##########
java/fory-core/src/test/java/org/apache/fory/CPPXlangTest.java:
##########
@@ -130,4 +130,16 @@ private void runBazelCommand(String... args) throws
IOException {
public void testConsistentNamed() throws java.io.IOException {
super.testConsistentNamed();
}
+
+ @Test
+ @Override
+ public void testStructWithUnionFields() throws java.io.IOException {
+ throw new SkipException("Union types not yet supported in C++");
Review Comment:
Could you add cpp tests in `cpp/fory/serialization/xlang_test_main.cc`?
Only added cpp tests, and make it pass, we can ensure union xlang
serialization is OK
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
