ariesdevil commented on code in PR #3080:
URL: https://github.com/apache/fory/pull/3080#discussion_r2643755530


##########
rust/fory-core/src/buffer.rs:
##########
@@ -192,6 +192,16 @@ impl<'a> Writer<'a> {
         }
     }
 
+    #[inline(always)]
+    pub fn write_i128(&mut self, value: i128) {
+        self.write_u128(value as u128);
+    }
+
+    #[inline(always)]
+    pub fn write_isize(&mut self, value: isize) {
+        self.write_i64(value as i64);

Review Comment:
   I just follow the `usize` way, let me change both `usize` and `isize` for 
different arches.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to