ariesdevil opened a new pull request, #3084: URL: https://github.com/apache/fory/pull/3084
<!-- **Thanks for contributing to Apache Fory™.** **If this is your first time opening a PR on fory, you can refer to [CONTRIBUTING.md](https://github.com/apache/fory/blob/main/CONTRIBUTING.md).** Contribution Checklist - The **Apache Fory™** community has requirements on the naming of pr titles. You can also find instructions in [CONTRIBUTING.md](https://github.com/apache/fory/blob/main/CONTRIBUTING.md). - Apache Fory™ has a strong focus on performance. If the PR you submit will have an impact on performance, please benchmark it first and provide the benchmark result here. --> ## Why? Add `UNION` and `NONE` to type ids that align with [xlang spec](https://github.com/apache/fory/blob/main/docs/specification/xlang_serialization_spec.md#internal-type-id-table) ## What does this PR do? This PR adds `UNION` and `NONE` to type ids: 1. add `UNION` and `NONE` to type ids 2. change `()` and `PhantomData` type id from `UNKNOWN` to `NONE` 3. skip early when encounter `NONE` in `skip_any_value` ## Related issues None ## Does this PR introduce any user-facing change? - [x] Does this PR introduce any public API change? - Yes, adds new public types support: `UNION` and `NONE` to TypeId - [ ] Does this PR introduce any binary protocol compatibility change? - No ## Benchmark <!-- When the PR has an impact on performance (if you don't know whether the PR will have an impact on performance, you can submit the PR first, and if it will have impact on performance, the code reviewer will explain it), be sure to attach a benchmark data here. Delete section if not applicable. --> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
