chaokunyang commented on code in PR #3092:
URL: https://github.com/apache/fory/pull/3092#discussion_r2647141406


##########
rust/fory-derive/src/object/read.rs:
##########
@@ -268,48 +291,59 @@ pub fn gen_read_type_info() -> TokenStream {
     }
 }
 
-fn get_fields_loop_ts(fields: &[&Field]) -> TokenStream {
-    let read_fields_ts: Vec<_> = fields
+fn get_sorted_fields_loop_ts(sorted_fields: &[SortedField<'_>]) -> TokenStream 
{

Review Comment:
   If we rename `SortedField` to `FieldInfo`, we can keep using 
`get_fields_loop_ts`



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to