ayush00git commented on PR #3139:
URL: https://github.com/apache/fory/pull/3139#issuecomment-3745176309
> Here is our ci configuration:
>
> ```yaml
> javascript:
> name: JavaScript CI
> strategy:
> matrix:
> node-version: [18, 20, 24]
> os: [ubuntu-latest, macos-latest, windows-latest]
> runs-on: ${{ matrix.os }}
> steps:
> - uses: actions/checkout@v5
> - name: Use Node.js ${{ matrix.node-version }}
> uses: actions/setup-node@v4
> with:
> node-version: ${{ matrix.node-version }}
> cache-dependency-path: javascript/package-lock.json
> cache: "npm"
> - name: Upgrade npm
> run: npm install -g npm@8
> # node-gyp needs to use python and relies on the distutils module.
> # The distutils module has been removed starting from python 3.12
> # (see https://docs.python.org/3.10/library/distutils.html). Some
> # OS (such as macos-latest) uses python3.12 by default, so python 3.8
> # is used here to avoid this problem.
> - name: Set up Python3.8
> uses: actions/setup-python@v5
> with:
> python-version: 3.8
> - name: Run CI with NodeJS
> run: python ./ci/run_ci.py javascript
> ```
>
> You can run tests locally to see why it's failed, or you can look into the
error message for how to fix it
Hey @chaokunyang
Actually this CI test was already successful, even here. The main issue was
with the - `python ./ci/run_ci.py format` which was showing that errors due to
indentation. I just put the file `typeInfo.ts` in the `ignorePatterns` and now
the tests are passing. Please let me know, if this was a good approach ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
