theweipeng commented on issue #3133: URL: https://github.com/apache/fory/issues/3133#issuecomment-3794409743
> Thanks for the clarification and for sharing the spec link. > > Since you are already working on JavaScriptXlangTest.java and opened PR [#3161](https://github.com/apache/fory/pull/3161), I’d like to focus on the JavaScript implementation side. My plan is: – Compare the current JavaScript xlang implementation with the “Data Types” section of the xlang serialization spec and the Java reference behavior. – Fix or extend the JavaScript encoder/decoder so that all base types follow the spec exactly. – Add or update JavaScript tests to cover these base types, without duplicating the Java JavaScriptXlangTest.java work you’re doing in [#3161](https://github.com/apache/fory/pull/3161). > > Please let me know if this division of work sounds good, or if you’d prefer me to help in a different way. It good to me. but you don't have to wait until all the functions are completed before submitting. Submit a PR as much as you have. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
