The GitHub Actions job "Fory CI" on 
fory.git/support_private_fields_of_cpp_class has failed.
Run started by GitHub user chaokunyang (triggered by chaokunyang).

Head commit for run:
74ece3fd6a1427efe30509486012c4be7b188a5d / Shawn Yang <[email protected]>
fix(cpp): use FORY_STRUCT_EXTERNAL for polymorphic types to avoid MSVC RTTI 
issues

Changed polymorphic types in smart_ptr_serializer_test from using FORY_STRUCT
inside the class to FORY_STRUCT_EXTERNAL outside the class. This avoids MSVC
RTTI access violations when using friend constexpr functions with polymorphic
types on Windows Server 2022.

Types changed:
- NestedContainer
- NestedContainerHolder
- PolymorphicBaseForMono
- NonDynamicFieldHolder

Also added static get() method to ForyFieldInfoDescriptor as part of earlier
fix attempt (not the final solution but kept for consistency).

The RTTI issue is specific to MSVC and occurs when FORY_STRUCT is used inside
polymorphic classes with virtual methods. Using FORY_STRUCT_EXTERNAL (which
defines the friend function outside the class) avoids this issue entirely.

All 15 smart_ptr_serializer tests now pass locally.

Report URL: https://github.com/apache/fory/actions/runs/21318502131

With regards,
GitHub Actions via GitBox


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to