chaokunyang commented on code in PR #3216:
URL: https://github.com/apache/fory/pull/3216#discussion_r2730738952
##########
python/pyfory/collection.pxi:
##########
@@ -200,7 +200,7 @@ cdef class CollectionSerializer(Serializer):
buffer.grow(<int32_t>max_size)
# Try batch write, fall back to slow path on error (e.g., int
overflow)
try:
- bytes_written = Fory_PyInt64SequenceWriteToBuffer(value,
buffer.c_buffer.get(), buffer.writer_index)
+ bytes_written = Fory_PyInt64SequenceWriteToBuffer(value,
&buffer.c_buffer, buffer.writer_index)
Review Comment:
do not pass `buffer.writer_index`, you can get it in
`Fory_PyInt64SequenceWriteToBuffer` from `c_buffer`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
