ayush00git commented on code in PR #3235:
URL: https://github.com/apache/fory/pull/3235#discussion_r2741037345
##########
go/fory/types.go:
##########
@@ -425,6 +435,21 @@ func GetDispatchId(t reflect.Type) DispatchId {
return Float32SliceDispatchId
case reflect.Float64:
return Float64SliceDispatchId
+ case reflect.Uint16:
+ // Check if it's float16 slice
+ if t.Elem().Name() == "Float16" && (t.Elem().PkgPath()
== "github.com/apache/fory/go/fory/float16" ||
strings.HasSuffix(t.Elem().PkgPath(), "/float16")) {
+ return Float16SliceDispatchId
+ }
+ return Int16SliceDispatchId // Standard uint16/int16
share serializer usually, wait: existing is Int16SliceDispatchId...
+ // Check existing Uint16 slice handling (it might be
missing or shared)
+ // Actually reflect.Uint16 case is missing in the
original switch shown in view_file.
+ // Wait, the original switch had:
Review Comment:
My bad
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
