ayush00git commented on issue #3210: URL: https://github.com/apache/fory/issues/3210#issuecomment-3839116742
What I found based on my research - 1. `float16` is defined in the binary writer but it fallbacks to `float32` while serialization. 2. We need to add `float16` to the `BinaryReaderBuilder` class. 3. Update the logic of `float16` fallback to `float32` and implement the correct `float16` method of serialization to the CodegenRegistery. Let me know if there are any much corrections to make, I'll go through these implementations and as the local testing feels fine, i'll raise a PR. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
