BrianLii commented on code in PR #3311:
URL: https://github.com/apache/fory/pull/3311#discussion_r2780668042
##########
go/fory/type_test.go:
##########
@@ -43,6 +43,9 @@ func TestTypeResolver(t *testing.T) {
"[]map[string][]map[string]*interface {}"},
{reflect.TypeOf((*A)(nil)), "*@example.A"},
{reflect.TypeOf((*A)(nil)).Elem(), "@example.A"},
+ {reflect.TypeOf([]uint16{}), "[]uint16"},
Review Comment:
Thanks for the review. Because this PR only fixes the type_resolver,
shouldn't the tests in `go/fory/type_test.go` be enough? I can also include the
test for `int8, int16, int32, int64` in `type_test.go`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
