dheeraj12347 commented on PR #3251: URL: https://github.com/apache/fory/pull/3251#issuecomment-3870421514
Hi @theweipeng and @chaokunyang, I am reaching out for some guidance as I've encountered a few hurdles while trying to clean up this PR according to your feedback. My Current Status: Rebase & Cleanup: I have successfully rebased the branch onto the latest main and narrowed the scope down from 180+ files to the ~24 relevant JavaScript files to remove the noise from benchmarks and documentation. Conflict Resolution: I have manually resolved the conflicts in crossLanguage.test.ts and index.ts. CI Failures: I am working on fixing the Code Style Check (License Headers) and the JavaScript CI (missing @types/jest dependency). Where I am Stuck: After the hard reset to align with the latest main branch, I am seeing some persistent environment issues in my local setup: I am encountering TypeScript compilation errors in the test suite regarding global identifiers (like describe and test). My local classResolver.ts logic was lost during a previous reset, and I am unsure if the version I am restoring is fully compliant with the architectural changes recently merged into main (specifically regarding the ForyField support). Request for Help: Could you provide a quick pointer on: The preferred location or pattern for the ClassResolver/TypeResolver logic within the current javascript/packages/fory structure? If there is a standard tsconfig or package.json template I should follow to ensure the CI environment matches my local dev environment for the test suite? I am committed to getting this merged correctly and appreciate your patience as I navigate the project's standards! Best regards, @dheeraj12347 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
