NotLebedev opened a new pull request, #3315: URL: https://github.com/apache/fory/pull/3315
<!-- **Thanks for contributing to Apache Fory™.** **If this is your first time opening a PR on fory, you can refer to [CONTRIBUTING.md](https://github.com/apache/fory/blob/main/CONTRIBUTING.md).** Contribution Checklist - The **Apache Fory™** community has requirements on the naming of pr titles. You can also find instructions in [CONTRIBUTING.md](https://github.com/apache/fory/blob/main/CONTRIBUTING.md). - Apache Fory™ has a strong focus on performance. If the PR you submit will have an impact on performance, please benchmark it first and provide the benchmark result here. --> ## Why? Fix `EnumSetSerializers` for enums that have overriding methods in vairants: ```java enum TestEnumWithMethods { A { @Override public void foo() { System.out.println("A"); } }, B, C { @Override public void foo() { } }, D; public void foo() { System.out.println("default"); } } ``` ## What does this PR do? `EnumSetSerializer` now correctly unwraps types of variants that extend base enum type. Doing it this way instead of writing class of variant and unwrapping it in read prevents writing additional classes for enum variants. ## Related issues - Fixes #3306 ## Does this PR introduce any user-facing change? <!-- If any user-facing interface changes, please [open an issue](https://github.com/apache/fory/issues/new/choose) describing the need to do so and update the document if necessary. Delete section if not applicable. --> - [ ] Does this PR introduce any public API change? - [x] Does this PR introduce any binary protocol compatibility change? This PR changes class of contained enum that `EnumSetSerializer` writes. Instead of writing class of enum variant if this variant extends base enum class it always writes class of base enum. This however does not break any existing code since previously `EnumSet`s of classes with overriding methods could not be deserialized at all ## Benchmark <!-- When the PR has an impact on performance (if you don't know whether the PR will have an impact on performance, you can submit the PR first, and if it will have impact on performance, the code reviewer will explain it), be sure to attach a benchmark data here. Delete section if not applicable. --> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
