BrianLii commented on code in PR #3313:
URL: https://github.com/apache/fory/pull/3313#discussion_r2790746051
##########
go/fory/slice_primitive_test.go:
##########
@@ -65,3 +67,351 @@ func TestFloat16Slice(t *testing.T) {
assert.Nil(t, result)
})
}
+
+func TestIntSlice(t *testing.T) {
+ f := NewFory()
+
+ t.Run("int_slice_large_numbers", func(t *testing.T) {
+ slice := []int{1, -2, 3, -4, 2147483647, -2147483648} //
Example with large int32 values
+ if strconv.IntSize == 64 {
+ slice = []int{1, -2, 3, -4, math.MaxInt64,
math.MinInt64} // For int64
Review Comment:
Thanks for catching this. I've updated using the arch-sized bounds.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
