chaokunyang commented on code in PR #3342:
URL: https://github.com/apache/fory/pull/3342#discussion_r2814722779
##########
java/fory-core/src/main/java/org/apache/fory/serializer/collection/MapLikeSerializer.java:
##########
@@ -853,43 +853,25 @@ private long readJavaChunkGeneric(
} else {
valueSerializer = valueGenericType.getSerializer(typeResolver);
}
- if (keyGenericType.hasGenericParameters() ||
valueGenericType.hasGenericParameters()) {
- for (int i = 0; i < chunkSize; i++) {
- generics.pushGenericType(keyGenericType);
- fory.incReadDepth();
- Object key =
- trackKeyRef
- ? binding.readRef(buffer, keySerializer)
- : binding.read(buffer, keySerializer);
- fory.decDepth();
- generics.popGenericType();
- generics.pushGenericType(valueGenericType);
- fory.incReadDepth();
- Object value =
- trackValueRef
- ? binding.readRef(buffer, valueSerializer)
- : binding.read(buffer, valueSerializer);
- fory.decDepth();
- generics.popGenericType();
- map.put(key, value);
- size--;
- }
- } else {
- for (int i = 0; i < chunkSize; i++) {
- // increase depth to avoid read wrong outer generic type
- fory.incReadDepth();
- Object key =
- trackKeyRef
- ? binding.readRef(buffer, keySerializer)
- : binding.read(buffer, keySerializer);
- Object value =
- trackValueRef
- ? binding.readRef(buffer, valueSerializer)
- : binding.read(buffer, valueSerializer);
- fory.decDepth();
- map.put(key, value);
- size--;
- }
Review Comment:
Good catch.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
