miantalha45 opened a new pull request, #3346:
URL: https://github.com/apache/fory/pull/3346
## Summary
Aligns the JavaScript buffer API with Java and other xlang implementations
by using explicit `read*` / `write*` method names only. No compatibility
aliases; one-shot breaking change.
## Changes
- **BinaryWriter** (`lib/writer/index.ts`): Removed short-name aliases
(`int8`, `uint8`, `int16`, etc.). Public write API is now only the existing
`write*` methods (e.g. `writeInt8`, `writeUint8`, `writeInt32`, `writeFloat64`,
`writeGetCursor`, etc.).
- **BinaryReader** (`lib/reader/index.ts`): Removed short-name aliases.
Public read API is now only the existing `read*` methods (e.g. `readInt8`,
`readUint8`, `readInt32`, `readGetCursor`, `readSetCursor`, `readSkip`, etc.).
- **Codegen** (`lib/gen/builder.ts`): `BinaryWriterBuilder` now emits
`write*` calls (e.g. `bw.writeInt8(...)`); `BinaryReaderBuilder` now emits
`read*` calls (e.g. `br.readInt8()`, `br.readGetCursor()`).
- **Tests** (`test/io.test.ts`): Updated dynamic writer calls from
`writer['uint${x}']` / `writer['int${x}']` to `writer['writeUint${x}']` /
`writer['writeInt${x}']`.
## Requirements met
- [x] Writer methods use `write*` prefix (e.g. `writeInt8`, `writeUint32`).
- [x] Reader methods use `read*` prefix (e.g. `readInt8`, `readUint32`).
- [x] One-shot breaking rename; no old names, aliases, or deprecation shims.
- [x] All internal call sites, codegen, and tests updated.
- [x] Runtime behavior and performance unchanged.
## Testing
- `cd javascript && node ./node_modules/.bin/jest --ci` — all 18 suites pass
(112 tests, 1 skipped).
Fixes #33345
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
