chaokunyang commented on code in PR #3382:
URL: https://github.com/apache/fory/pull/3382#discussion_r2835639607
##########
javascript/packages/fory/lib/gen/serializer.ts:
##########
@@ -200,12 +200,8 @@ export abstract class BaseSerializerGenerator implements
SerializerGenerator {
readNoRef(assignStmt: (v: string) => string, refState: string): string {
return `
fory.incReadDepth();
- try {
- ${this.readTypeInfo()}
- ${this.read(assignStmt, refState)};
- } finally {
- fory.decReadDepth();
- }
+ ${this.readTypeInfo()}
+ ${this.read(assignStmt, refState)};
Review Comment:
I am also curious why the tests don't fail? The tests for depth is also wrong
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
