Zakir032002 commented on PR #3329: URL: https://github.com/apache/fory/pull/3329#issuecomment-3950648741
@asadjan4611 your question about failing checks — here's what's actually going on **rebase on main — this is the root cause** PR #3348 was merged on Feb 18 (6 days after you opened this). it removed `xwrite/xread` and `XlangCompatibleSerializer` entirely. your branch predates that, so everything you added referencing those in `serialization.pyx`, `_serializer.py`, `primitive.pxi`, `serializer.py` conflicts with current main. ```bash git fetch upstream git rebase upstream/main ``` after rebasing drop all `xwrite/xread` methods you added — the unified API only uses `write/read` now. **also CRLF line endings are failing the linter** `_serializer.py` and `primitive.pxi` were saved with `\r\n` windows endings — whole files show as modified. add this to `.gitattributes`: ``` *.py text eol=lf *.pyx text eol=lf *.pxd text eol=lf *.pxi text eol=lf ``` then `git add --renormalize . && git commit -m "fix: normalize line endings"` **and the open review threads from @chaokunyang** three things still unaddressed from his review on Feb 21 — remove the `try/except` on the bfloat16 import in `registry.py` (it should always be available), rename `BFloat16` → `bfloat16` to match the lowercase primitive style, and drop `XlangCompatibleSerializer` references which no longer exist post #3348. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
