chaokunyang commented on code in PR #3434:
URL: https://github.com/apache/fory/pull/3434#discussion_r2867272619
##########
dart/packages/fory/lib/src/serializer/collection/map/map_serializer.dart:
##########
@@ -51,6 +52,11 @@ abstract base class MapSerializer<T extends Map<Object?,
Object?>>
@override
T read(ByteReader br, int refId, DeserializationContext pack) {
int remaining = br.readVarUint32Small7();
+ final int? maxCollectionSize = pack.config.maxCollectionSize;
Review Comment:
you should set a default value for maxCollectionSize and maxBinary Size
instead use null to span across whole repo
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
