ayush00git commented on issue #3446: URL: https://github.com/apache/fory/issues/3446#issuecomment-3988720372
Removing `//go:noinline` from `growSlow()` does fix the write path, drops from cost 85 → 75, now under budget. However, the read path functions are unaffected because their cost comes from the inline `BufferOutOfBoundError()` construction, not from grow(). We still need to move the error construction to a `//go:noinline` helper to fix those. Also, the `//go:inline` comments throughout the file can be removed — the` gc` compiler doesn't recognize `//go:inline` as a directive. It automatically inlines any function with cost under 80. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
