chaokunyang commented on code in PR #3451:
URL: https://github.com/apache/fory/pull/3451#discussion_r2881905419
##########
csharp/src/Fory/Context.cs:
##########
@@ -268,6 +383,8 @@ public ReadContext(
public bool CheckStructVersion { get; }
+ public bool ShouldConsumeCompatibleTypeMeta =>
_shouldConsumeCompatibleTypeMeta;
Review Comment:
[P3] Unused compatible-meta expectation state is dead code
`ShouldConsumeCompatibleTypeMeta`, `ReplaceCompatibleTypeMetaExpectation`,
and `RestoreCompatibleTypeMetaExpectation` are introduced but never read by any
serializer/runtime path in this PR. Keeping this state machine unused adds
maintenance overhead and makes compatible-read flow harder to reason about
without delivering behavior.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
