The GitHub Actions job "Fory CI" on fory.git/main has succeeded. Run started by GitHub user chaokunyang (triggered by chaokunyang).
Head commit for run: ed586af222327bb2c3e7220832c991f211920005 / Ayush Kumar <[email protected]> perf(go): remove //go:inline directives and mark cold paths as //go:noinline (#3456) ## Why? //go:inline directives were introduced in the go runtime, expecting the gc compiler would inline that specific function. But //go:inline isn't a directive that is recognized by the gc compiler. gc compiler automatically inlines a function which costs less than 80. ## What does this PR do? 1. Removes all occurrences of //go:inline. 2. Mark cold paths as //go:noinline. ## Related issues Closes #3446 ## Does this PR introduce any user-facing change? - [ ] Does this PR introduce any public API change? - [ ] Does this PR introduce any binary protocol compatibility change? ## Benchmark main branch - <img width="1114" height="811" alt="image" src="https://github.com/user-attachments/assets/75f1dbea-7110-484b-8233-ac5599137cf6" /> this branch - <img width="1114" height="811" alt="image" src="https://github.com/user-attachments/assets/50d8b9cd-f4e9-48a0-a81d-36e47ac32947" /> Report URL: https://github.com/apache/fory/actions/runs/22835882864 With regards, GitHub Actions via GitBox --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
