chaokunyang commented on code in PR #3483:
URL: https://github.com/apache/fory/pull/3483#discussion_r2973507884
##########
rust/fory-core/src/row/bit_util.rs:
##########
@@ -18,5 +18,5 @@
const WORD_SIZE: usize = 8;
pub fn calculate_bitmap_width_in_bytes(num_fields: usize) -> usize {
- ((num_fields + 63) / 64) * WORD_SIZE
+ (num_fields.saturating_add(63) / 64).saturating_mul(WORD_SIZE)
Review Comment:
This change behaviour, I think you should let it crash. Such crash is
basically programming error
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
