miantalha45 commented on code in PR #3394:
URL: https://github.com/apache/fory/pull/3394#discussion_r3044609274
##########
javascript/packages/core/lib/meta/TypeMeta.ts:
##########
@@ -238,8 +238,8 @@ export class TypeMeta {
}
computeStructHash() {
- const fields = TypeMeta.groupFieldsByType(this.fields);
- const fingerprint = this.computeStructFingerprint(fields);
+ // const fields = TypeMeta.groupFieldsByType(this.fields);
Review Comment:
computeStructFingerprint sorts fields alphabetically by field identifier
regardless of input order, so even if the grouping were different, the
resulting hash would be the same.
but your point is also valid, i will uncomment it and will group fields by
type.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
