chaokunyang commented on code in PR #3723: URL: https://github.com/apache/fory/pull/3723#discussion_r3418728894
########## compiler/fory_compiler/tests/test_dart_grpc_analyze.py: ########## @@ -0,0 +1,145 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file +# distributed with this work for additional information +# regarding copyright ownership. The ASF licenses this file +# to you under the Apache License, Version 2.0 (the +# "License"); you may not use this file except in compliance +# with the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, +# software distributed under the License is distributed on an +# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +# KIND, either express or implied. See the License for the +# specific language governing permissions and limitations +# under the License. + +"""dart analyze smoke test for emitted Dart gRPC files. Review Comment: This test should not live under compiler pytest. It shells out to `dart pub get`, `dart format`, and `dart analyze`, and it validates the generated Dart gRPC companion rather than compiler-only behavior. The owner should be the Dart gRPC integration test path under `integration_tests/grpc_tests/dart` (or the Java-driven gRPC integration harness that already installs Dart), so CI exercises it with the Dart toolchain instead of adding a compiler test that skips when Dart is absent. Please move this validation there and remove this compiler-level test file. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
