chaokunyang commented on issue #3787: URL: https://github.com/apache/fory/issues/3787#issuecomment-4795812778
I think the proposed direction is reasonable, with one clarification on the public type model. C++ should support both the Fory-owned temporal carrier types and the corresponding C++ chrono types, but the default FDL/codegen carrier should be the Fory type. The dynamic/polymorphic path should use the same canonical carrier as well, so deserializing a `duration` or `timestamp` value without a static target type should produce `fory::serialization::Duration` or `fory::serialization::Timestamp`, not a chrono type. The chrono types should remain supported as explicit C++ adaptation types, for example when a user writes a field or calls deserialization with a chrono target type. The Fory carrier types should provide clear conversion APIs to and from the chrono representations. Please also include API documentation for the new carrier types and the chrono conversion methods in the PR. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
