chaokunyang opened a new pull request, #3908:
URL: https://github.com/apache/fory/pull/3908

   ## Why?
   
   Fory JSON date/time fields currently use only their built-in textual 
representations. Applications
   need a field-owned way to select a deterministic `DateTimeFormatter` pattern 
without registering a
   complete custom codec for every occurrence.
   
   ## What does this PR do?
   
   - adds the field-only `JsonFormat(pattern = ...)` annotation;
   - applies the pattern to direct supported date/time values and one direct 
wrapper child, including
     `Optional`, arrays, `Collection`/`List`/`Set`, `AtomicReference`, 
`AtomicReferenceArray`, and Map
     values;
   - rejects nested or ambiguous wrapper shapes, Map keys, complete wrapper 
representations, and
     conflicting representation annotations;
   - keeps formatter construction and annotation resolution on the cold 
metadata path, reuses the
     existing generated/interpreted codec capability path, writes without an 
intermediate String, and
     parses ordinary ASCII input through the reader's reusable view;
   - supports runtime and processor Mixins, generated companions, Android, and 
GraalVM retention;
   - documents the exact supported types, root-locale behavior, UTC `Instant` 
behavior, and unsupported
     cases.
   
   ## Related issues
   
   None.
   
   ## AI Contribution Checklist
   
   - [x] Substantial AI assistance was used in this PR: `yes`
   - [x] If `yes`, I included the standardized `AI Usage Disclosure` block 
below.
   - [ ] If `yes`, I can explain and defend all important changes without AI 
help.
   - [ ] If `yes`, I reviewed AI-assisted code changes line by line before 
submission.
   - [ ] If `yes`, I completed line-by-line self-review first and fixed issues 
before requesting AI review.
   - [x] If `yes`, I ran two fresh AI review agents on the current HEAD: one 
Fory-guided reviewer and one independent general reviewer.
   - [x] If `yes`, I addressed all AI review comments and repeated the review 
loop until both reviewers reported no further actionable comments.
   - [ ] If `yes`, I attached persisted links to both final clean review 
results in this PR body.
   - [ ] If `yes`, I ran adequate human verification and recorded the reviewed 
evidence.
   - [x] If `yes`, I added or updated tests and documentation where required.
   - [ ] If `yes`, I validated performance impacts with the evidence required 
by project policy.
   - [ ] If `yes`, I verified licensing and provenance compliance.
   
   AI Usage Disclosure
   
   - substantial_ai_assistance: yes
   - scope: design drafting, implementation, tests, documentation, and 
review-driven corrections
   - affected_files_or_subsystems: `java/fory-json`, 
`java/fory-annotation-processor`, and Java JSON platform/user guides
   - ai_review: implementation self-review and a two-reviewer correction loop 
completed; both fresh final reviewers reported no further actionable comments 
on `9e89fea1c521f37638560c0b8604d0c63afebb77`; human attestation remains pending
   - ai_review_artifacts: pending persisted PR comment links
   - human_verification: automated local checks passed; contributor review and 
attestation remain pending
   - performance_verification: no benchmark was run per task scope; unannotated 
value paths have no new per-value branch or allocation, formatter construction 
is cold, formatted writes avoid intermediate Strings, and ASCII reads reuse the 
reader view
   - provenance_license_confirmation: no third-party source was copied by the 
implementation workflow; contributor confirmation remains pending
   
   This PR remains a draft until the unchecked human-only policy items are 
completed by the submitter.
   
   ## Does this PR introduce any user-facing change?
   
   - [x] Does this PR introduce any public API change?
   - [ ] Does this PR introduce any binary protocol compatibility change?
   
   ## Benchmark
   
   Not run, as explicitly requested for this task. The change does not alter 
the binary or xlang
   protocol and does not add per-value work to unannotated JSON fields. The 
implementation was reviewed
   for allocation behavior; ambiguous legacy date types that required 
write-time conversion allocation
   were excluded from the first version.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to