ayush00git opened a new pull request, #4014:
URL: https://github.com/apache/fory/pull/4014

   ## What was the error
   `Type.struct(0, ...)`, `Type.ext(0)`, and `Type.enum(0, ...)` threw `type 
name and type id should be set at least one` because a truthiness check treated 
the numeric id 0 as absent, although `TypeInfo` allows user type ids in `[0, 
0xfffffffe]`. A peer runtime registering a type under id 0 could not 
interoperate with JavaScript.
   
   ## What this PR fixes
   The three factories now check `typeId === undefined` instead of truthiness, 
so id 0 registers normally. A regression test covers all three factories and a 
full serialize/deserialize round trip under id 0.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to