chaokunyang commented on code in PR #1273: URL: https://github.com/apache/incubator-fury/pull/1273#discussion_r1437964421
########## java/fury-core/src/main/java/org/apache/fury/reflect/TypeToken.java: ########## @@ -0,0 +1,330 @@ +/* + * Copyright (C) 2006 The Guava Authors + * + * Licensed under the Apache License, Version 2.0 (the "License"); you may not use this file except + * in compliance with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software distributed under the License + * is distributed on an "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express + * or implied. See the License for the specific language governing permissions and limitations under + * the License. + */ + +package org.apache.fury.reflect; + +import com.google.common.reflect.TypeParameter; Review Comment: Could we implement `TypeToken` by ourself without depending on any guava API. `org.apache.fury.type.GenericType#build(java.lang.reflect.Type, java.util.function.Predicate<java.lang.reflect.Type>)` can be taken as an example. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
