PragmaTwice commented on code in PR #1303: URL: https://github.com/apache/incubator-fury/pull/1303#discussion_r1442444126
########## ci/run_ci.py: ########## @@ -0,0 +1,107 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file +# distributed with this work for additional information +# regarding copyright ownership. The ASF licenses this file +# to you under the Apache License, Version 2.0 (the +# "License"); you may not use this file except in compliance +# with the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, +# software distributed under the License is distributed on an +# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +# KIND, either express or implied. See the License for the +# specific language governing permissions and limitations +# under the License. + + +import argparse +import subprocess +import platform +import psutil +import urllib.request as ulib +import os + + +def _exec_cmd(cmd: str): + print(f"run command: {cmd}") + result = subprocess.check_output(cmd, shell=True).decode("utf-8") + print(result) + return result + + +def _get_os_name_lower(): + return platform.system().lower() + + +def _get_os_machine(): + return platform.machine() + + +def _install_bazel(): + os_name = _get_os_name_lower() + if os_name == "windows": + # TODO: Implement Windows download bazel. Review Comment: We can assume that these things are already installed. And also the en var is optional to set. ########## ci/run_ci.py: ########## @@ -0,0 +1,107 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file +# distributed with this work for additional information +# regarding copyright ownership. The ASF licenses this file +# to you under the Apache License, Version 2.0 (the +# "License"); you may not use this file except in compliance +# with the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, +# software distributed under the License is distributed on an +# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +# KIND, either express or implied. See the License for the +# specific language governing permissions and limitations +# under the License. + + +import argparse +import subprocess +import platform +import psutil +import urllib.request as ulib +import os + + +def _exec_cmd(cmd: str): + print(f"run command: {cmd}") + result = subprocess.check_output(cmd, shell=True).decode("utf-8") + print(result) + return result + + +def _get_os_name_lower(): + return platform.system().lower() + + +def _get_os_machine(): + return platform.machine() + + +def _install_bazel(): + os_name = _get_os_name_lower() + if os_name == "windows": + # TODO: Implement Windows download bazel. Review Comment: We can assume that these things are already installed. And also the environment variable is optional to set. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
