theweipeng commented on PR #1313: URL: https://github.com/apache/incubator-fury/pull/1313#issuecomment-1879597937
> it seem that this is not a problem, all the call will happen in this closure > > <img alt="image" width="1149" src="https://private-user-images.githubusercontent.com/13938334/294660531-5a43b6e1-523e-4145-82ed-5900f5ca1e6e.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MDQ1MzEzMDcsIm5iZiI6MTcwNDUzMTAwNywicGF0aCI6Ii8xMzkzODMzNC8yOTQ2NjA1MzEtNWE0M2I2ZTEtNTIzZS00MTQ1LTgyZWQtNTkwMGY1Y2ExZTZlLnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNDAxMDYlMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjQwMTA2VDA4NTAwN1omWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPWZiZjc2ZmJlNmJhYTQ5OWRmNTRkY2VhNzYxZTFhY2YxZTg4Yjk0OTE4MzdjZjczMGY5ZmIwZTgyYjFiZDI5NGUmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0JmFjdG9yX2lkPTAma2V5X2lkPTAmcmVwb19pZD0wIn0.D3ZFZNlAogNWEPaogXbBpI_jPsSwUvjKg_LRS-YTEnk";> > I checked the snapshot and donot sure is this a problem? This is not a problem, but declare the readInner before the read is better. I will change it -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
![https://private-user-images.githubusercontent.com/13938334/294660531-5a43b6e1-523e-4145-82ed-5900f5ca1e6e.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MDQ1MzEzMDcsIm5iZiI6MTcwNDUzMTAwNywicGF0aCI6Ii8xMzkzODMzNC8yOTQ2NjA1MzEtNWE0M2I2ZTEtNTIzZS00MTQ1LTgyZWQtNTkwMGY1Y2ExZTZlLnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNDAxMDYlMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjQwMTA2VDA4NTAwN1omWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPWZiZjc2ZmJlNmJhYTQ5OWRmNTRkY2VhNzYxZTFhY2YxZTg4Yjk0OTE4MzdjZjczMGY5ZmIwZTgyYjFiZDI5NGUmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0JmFjdG9yX2lkPTAma2V5X2lkPTAmcmVwb19pZD0wIn0.D3ZFZNlAogNWEPaogXbBpI_jPsSwUvjKg_LRS-YTEnk"](https://private-user-images.githubusercontent.com/13938334/294660531-5a43b6e1-523e-4145-82ed-5900f5ca1e6e.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MDQ1MzEzMDcsIm5iZiI6MTcwNDUzMTAwNywicGF0aCI6Ii8xMzkzODMzNC8yOTQ2NjA1MzEtNWE0M2I2ZTEtNTIzZS00MTQ1LTgyZWQtNTkwMGY1Y2ExZTZlLnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNDAxMDYlMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjQwMTA2VDA4NTAwN1omWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPWZiZjc2ZmJlNmJhYTQ5OWRmNTRkY2VhNzYxZTFhY2YxZTg4Yjk0OTE4MzdjZjczMGY5ZmIwZTgyYjFiZDI5NGUmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0JmFjdG9yX2lkPTAma2V5X2lkPTAmcmVwb19pZD0wIn0.D3ZFZNlAogNWEPaogXbBpI_jPsSwUvjKg_LRS-YTEnk"){kind=link}