bytemain commented on code in PR #1337:
URL: https://github.com/apache/incubator-fury/pull/1337#discussion_r1449966999
##########
javascript/test/__snapshots__/codeGen.test.ts.snap:
##########
@@ -8,13 +8,13 @@ return function(fury, external) {
const bw = fury.binaryWriter;
const cr = fury.classResolver;
const rr = fury.referenceResolver;
- const tag_ser_3 = fury.classResolver.getSerializerByTag("example.foo.1");
- const tag_ser_4 = fury.classResolver.getSerializerByTag("example.foo.2");
- const tag_ser_12 = fury.classResolver.getSerializerByTag("example.bar.1");
- const tag_ser_13 = fury.classResolver.getSerializerByTag("example.bar.2");
- const tagWriter_19 = cr.createTagWriter("tuple-object-wrapper");
+ const tag_ser_4 = fury.classResolver.getSerializerByTag("example.foo.1");
Review Comment:
.snap is used in unittest, it can ensure the generated code to match our
expectation
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
