LiangliangSui commented on code in PR #1408:
URL: https://github.com/apache/incubator-fury/pull/1408#discussion_r1527102186
##########
java/fury-core/src/main/java/org/apache/fury/resolver/ClassResolver.java:
##########
@@ -305,33 +304,26 @@ public void initialize() {
private void addDefaultSerializers() {
// primitive types will be boxed.
- addDefaultSerializer(String.class, new StringSerializer(fury));
+ StringSerializer.registerDefaultSerializers(fury);
PrimitiveSerializers.registerDefaultSerializers(fury);
Serializers.registerDefaultSerializers(fury);
ArraySerializers.registerDefaultSerializers(fury);
TimeSerializers.registerDefaultSerializers(fury);
OptionalSerializers.registerDefaultSerializers(fury);
CollectionSerializers.registerDefaultSerializers(fury);
MapSerializers.registerDefaultSerializers(fury);
- addDefaultSerializer(Locale.class, new LocaleSerializer(fury));
Review Comment:
Yes, but it may be better in design to move them into their own Serializers,
which are only responsible for calling their respective
`Serializer#registerDefaultSerializers`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
