chaokunyang commented on code in PR #1450:
URL: https://github.com/apache/incubator-fury/pull/1450#discussion_r1547826521
##########
java/fury-core/src/main/java/org/apache/fury/memory/MemoryBuffer.java:
##########
@@ -1316,24 +1316,15 @@ public int readPositiveVarInt() {
}
private int readPositiveVarIntSlow() {
- int b = readByte();
- int result = b & 0x7F;
- if ((b & 0x80) != 0) {
+ int shift = 0;
Review Comment:
Yes, could you add some comments in this pr? I think we'd better add
comments to similar methods
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
