chaokunyang commented on code in PR #1472:
URL: https://github.com/apache/incubator-fury/pull/1472#discussion_r1554641365


##########
java/fury-core/src/test/java/org/apache/fury/serializer/PrimitiveSerializersTest.java:
##########
@@ -54,4 +59,62 @@ public void testUint16Serializer() {
     assertThrows(IllegalArgumentException.class, () -> 
serializer.xwrite(buffer, -1));
     assertThrows(IllegalArgumentException.class, () -> 
serializer.xwrite(buffer, 65536));
   }
+
+  @Data
+  @AllArgsConstructor
+  public static class PrimitiveStruct {

Review Comment:
   Private will work here too, but the generate code would be different. 
Codegen work best for public classes



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to