LiangliangSui commented on code in PR #1487:
URL: https://github.com/apache/incubator-fury/pull/1487#discussion_r1560517624
##########
javascript/packages/fury/lib/classResolver.ts:
##########
@@ -84,35 +84,34 @@ export default class SerializerResolver {
private writeStringIndex: number[] = [];
private registerSerializer(fury: Fury, description: TypeDescription) {
- return fury.classResolver.registerSerializerById(description.type,
generateSerializer(fury, description));
+ return
fury.classResolver.registerSerializerById(SerializerResolver.getTypeIdByInternalSerializerType(description.type),
generateSerializer(fury, description));
}
private initInternalSerializer(fury: Fury) {
this.registerSerializer(fury, Type.string());
this.registerSerializer(fury, Type.array(Type.any()));
this.registerSerializer(fury, Type.map(Type.any(), Type.any()));
this.registerSerializer(fury, Type.bool());
- this.registerSerializer(fury, Type.uint8());
this.registerSerializer(fury, Type.int8());
- this.registerSerializer(fury, Type.uint16());
this.registerSerializer(fury, Type.int16());
- this.registerSerializer(fury, Type.uint32());
this.registerSerializer(fury, Type.int32());
- this.registerSerializer(fury, Type.uint64());
+ this.registerSerializer(fury, Type.varInt32());
this.registerSerializer(fury, Type.int64());
- this.registerSerializer(fury, Type.float());
- this.registerSerializer(fury, Type.double());
+ this.registerSerializer(fury, Type.sliInt64());
+ this.registerSerializer(fury, Type.float16());
+ this.registerSerializer(fury, Type.float32());
+ this.registerSerializer(fury, Type.float64());
this.registerSerializer(fury, Type.timestamp());
- this.registerSerializer(fury, Type.date());
+ this.registerSerializer(fury, Type.duration());
this.registerSerializer(fury, Type.set(Type.any()));
this.registerSerializer(fury, Type.binary());
- this.registerSerializer(fury, Type.stringTypedArray());
- this.registerSerializer(fury, Type.boolTypedArray());
- this.registerSerializer(fury, Type.shortTypedArray());
- this.registerSerializer(fury, Type.intTypedArray());
- this.registerSerializer(fury, Type.longTypedArray());
- this.registerSerializer(fury, Type.floatTypedArray());
- this.registerSerializer(fury, Type.doubleTypedArray());
+ this.registerSerializer(fury, Type.boolArray());
Review Comment:
`int8Array` should also be added here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
