chaokunyang commented on code in PR #1492:
URL: https://github.com/apache/incubator-fury/pull/1492#discussion_r1561111480
##########
java/fury-core/src/main/java/org/apache/fury/logging/FuryLogger.java:
##########
@@ -23,88 +23,139 @@
import java.time.format.DateTimeFormatter;
public class FuryLogger implements Logger {
+
+ private static final int ERROR_LEVEL = 0;
+
+ private static final int WARN_LEVEL = 1;
+
+ private static final int INFO_LEVEL = 2;
+
+ // Default is INFO level.
+ private static final int LEVEL = INFO_LEVEL;
Review Comment:
how aboubt make it as a final field of `FuryLogger`, and pass it from
`LoggerFactory` to allow users to custimize level
##########
java/fury-core/src/main/java/org/apache/fury/logging/FuryLogger.java:
##########
@@ -23,88 +23,139 @@
import java.time.format.DateTimeFormatter;
public class FuryLogger implements Logger {
+
+ private static final int ERROR_LEVEL = 0;
+
+ private static final int WARN_LEVEL = 1;
+
+ private static final int INFO_LEVEL = 2;
+
+ // Default is INFO level.
+ private static final int LEVEL = INFO_LEVEL;
Review Comment:
how about make it as a final field of `FuryLogger`, and pass it from
`LoggerFactory` to allow users to custimize level
##########
java/fury-core/src/main/java/org/apache/fury/logging/FuryLogger.java:
##########
@@ -23,88 +23,139 @@
import java.time.format.DateTimeFormatter;
public class FuryLogger implements Logger {
+
+ private static final int ERROR_LEVEL = 0;
+
+ private static final int WARN_LEVEL = 1;
+
+ private static final int INFO_LEVEL = 2;
+
+ // Default is INFO level.
+ private static final int LEVEL = INFO_LEVEL;
Review Comment:
how about making it as a final field of `FuryLogger`, and pass it from
`LoggerFactory` to allow users to custimize level
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
