chaokunyang commented on code in PR #1539:
URL: https://github.com/apache/incubator-fury/pull/1539#discussion_r1571040169
##########
python/pyfury/_serialization.pyx:
##########
@@ -1058,6 +1061,11 @@ cdef class Fury:
self.unpickler = Unpickler(buffer)
if unsupported_objects is not None:
self._unsupported_objects = iter(unsupported_objects)
+ if self.language == Language.XLANG:
+ magic_numer = buffer.read_int16()
+ assert magic_numer == MAGIC_NUMBER, (
+ "The XLANG cross-language protocol is not currently used. For
details, see "
Review Comment:
Clang and cross language seems a little redundant. Other parts look good to
me. But could we refine the error message？
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
