chaokunyang commented on code in PR #1549:
URL: https://github.com/apache/incubator-fury/pull/1549#discussion_r1573598763
##########
javascript/packages/fury/lib/classResolver.ts:
##########
@@ -114,8 +115,26 @@ export default class SerializerResolver {
this.registerSerializer(fury, Type.float16Array());
this.registerSerializer(fury, Type.float32Array());
this.registerSerializer(fury, Type.float64Array());
+
+ this.numberSerializer =
this.getSerializerById(SerializerResolver.getTypeIdByInternalSerializerType(InternalSerializerType.FLOAT64));
+ this.bigintSerializer =
this.getSerializerById(SerializerResolver.getTypeIdByInternalSerializerType(InternalSerializerType.INT64));
Review Comment:
Maybe not in this PR, could we rename bigint to int64? Normally bigint means
an unlimited integer which can represent number of any bits
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
