LiangliangSui commented on code in PR #1557:
URL: https://github.com/apache/incubator-fury/pull/1557#discussion_r1575741501
##########
java/fury-core/src/main/java/org/apache/fury/logging/LoggerFactory.java:
##########
@@ -32,6 +32,7 @@ public class LoggerFactory {
/** Disable Logger, there will be no log output. */
public static void disableLogging() {
disableLogging = true;
+ logLevel = LogLevel.ERROR_LEVEL - 1;
Review Comment:
Could we use `logLevel` instead of `disableLogging` field?
Because currently `disableLogging` field is equivalent to `logLevel ==
LogLevel.ERROR_LEVEL - 1`, so we can remove the judgment in `setLogLevel`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
