(incubator-fury) branch main updated: fix(license): remove confused comment and remove generics (#1563)

[chaokunyang]

This is an automated email from the ASF dual-hosted git repository.

chaokunyang pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/incubator-fury.git


The following commit(s) were added to refs/heads/main by this push:
     new e469b1aa fix(license): remove confused comment and remove generics 
(#1563)
e469b1aa is described below

commit e469b1aad670f3084e293256abf5958b584820bd
Author: Shawn Yang <shawn.ck.y...@gmail.com>
AuthorDate: Wed Apr 24 17:25:54 2024 +0800

    fix(license): remove confused comment and remove generics (#1563)
    
    ## What does this PR do?
    
    This PR removed confused comment and remove generics.
    
    ## Related issues
    #1560
    
    ## Does this PR introduce any user-facing change?
    
    <!--
    If any user-facing interface changes, please [open an
    issue](https://github.com/apache/incubator-fury/issues/new/choose)
    describing the need to do so and update the document if necessary.
    -->
    
    - [ ] Does this PR introduce any public API change?
    - [ ] Does this PR introduce any binary protocol compatibility change?
    
    
    ## Benchmark
    
    <!--
    When the PR has an impact on performance (if you don't know whether the
    PR will have an impact on performance, you can submit the PR first, and
    if it will have impact on performance, the code reviewer will explain
    it), be sure to attach a benchmark data here.
    -->
---
 .../apache/fury/serializer/ArraySerializers.java   |  4 +--
 .../collection/FuryArrayAsListSerializer.java      | 30 ++++++++++------------
 2 files changed, 16 insertions(+), 18 deletions(-)

diff --git 
a/java/fury-core/src/main/java/org/apache/fury/serializer/ArraySerializers.java 
b/java/fury-core/src/main/java/org/apache/fury/serializer/ArraySerializers.java
index 6ed4284d..5e193e8c 100644
--- 
a/java/fury-core/src/main/java/org/apache/fury/serializer/ArraySerializers.java
+++ 
b/java/fury-core/src/main/java/org/apache/fury/serializer/ArraySerializers.java
@@ -544,14 +544,14 @@ public class ArraySerializers {
   public static final class StringArraySerializer extends Serializer<String[]> 
{
     private final StringSerializer stringSerializer;
     private final FuryArrayAsListSerializer collectionSerializer;
-    private final FuryArrayAsListSerializer.ArrayAsList<String> list;
+    private final FuryArrayAsListSerializer.ArrayAsList list;
 
     public StringArraySerializer(Fury fury) {
       super(fury, String[].class);
       stringSerializer = new StringSerializer(fury);
       collectionSerializer = new FuryArrayAsListSerializer(fury);
       collectionSerializer.setElementSerializer(stringSerializer);
-      list = new FuryArrayAsListSerializer.ArrayAsList<>(0);
+      list = new FuryArrayAsListSerializer.ArrayAsList(0);
     }
 
     @Override
diff --git 
a/java/fury-core/src/main/java/org/apache/fury/serializer/collection/FuryArrayAsListSerializer.java
 
b/java/fury-core/src/main/java/org/apache/fury/serializer/collection/FuryArrayAsListSerializer.java
index 727cb811..057acb7b 100644
--- 
a/java/fury-core/src/main/java/org/apache/fury/serializer/collection/FuryArrayAsListSerializer.java
+++ 
b/java/fury-core/src/main/java/org/apache/fury/serializer/collection/FuryArrayAsListSerializer.java
@@ -49,20 +49,19 @@ public final class FuryArrayAsListSerializer
   }
 
   /**
-   * A List which wrap a Java array like `java.util.Arrays.ArrayList`, but 
allow to replace wrapped
-   * array. Used for serialization only, do not use it in other scenarios.
+   * A List which wrap a Java array into a list, used for serialization only, 
do not use it in other
+   * scenarios.
    */
   @Internal
-  public static class ArrayAsList<E> extends AbstractList<E>
+  public static class ArrayAsList extends AbstractList<Object>
       implements RandomAccess, java.io.Serializable {
     private static final Object[] EMPTY = new Object[0];
 
-    private E[] array;
+    private Object[] array;
     private int size;
 
-    @SuppressWarnings("unchecked")
     public ArrayAsList(int size) {
-      array = (E[]) new Object[size];
+      array = new Object[size];
     }
 
     @Override
@@ -71,33 +70,32 @@ public final class FuryArrayAsListSerializer
     }
 
     @Override
-    public boolean add(E e) {
+    public boolean add(Object e) {
       array[size++] = e;
       return true;
     }
 
     @Override
-    public E get(int index) {
+    public Object get(int index) {
       return array[index];
     }
 
-    @SuppressWarnings("unchecked")
     public void clearArray() {
       size = 0;
-      array = (E[]) EMPTY;
+      array = EMPTY;
     }
 
-    public void setArray(E[] a) {
+    public void setArray(Object[] a) {
       array = a;
       size = a.length;
     }
 
-    public E[] getArray() {
+    public Object[] getArray() {
       return array;
     }
 
     @Override
-    public E set(int index, E element) {
+    public Object set(int index, Object element) {
       throw new UnsupportedOperationException();
     }
 
@@ -118,8 +116,8 @@ public final class FuryArrayAsListSerializer
     }
 
     @Override
-    public Iterator<E> iterator() {
-      return new Iterator<E>() {
+    public Iterator<Object> iterator() {
+      return new Iterator<Object>() {
         private int index;
 
         @Override
@@ -128,7 +126,7 @@ public final class FuryArrayAsListSerializer
         }
 
         @Override
-        public E next() {
+        public Object next() {
           return array[index++];
         }
       };


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@fury.apache.org
For additional commands, e-mail: commits-h...@fury.apache.org