qingoba commented on code in PR #1566: URL: https://github.com/apache/incubator-fury/pull/1566#discussion_r1578781200
########## go/fury/meta/meta_string_encoder.go: ########## @@ -0,0 +1,261 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor license agreements. See the NOTICE file +// distributed with this work for additional information +// regarding copyright ownership. The ASF licenses this file +// to you under the Apache License, Version 2.0 (the +// "License"); you may not use this file except in compliance +// with the License. You may obtain a copy of the License at +// +// http://www.apache.org/licenses/LICENSE-2.0 +// +// Unless required by applicable law or agreed to in writing, +// software distributed under the License is distributed on an +// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +// KIND, either express or implied. See the License for the +// specific language governing permissions and limitations +// under the License. + +package meta + +import ( + "fmt" + "unicode" +) + +type Encoder struct { + specialChar1 byte + specialChar2 byte +} + +func NewEncoder(specialCh1 byte, specialCh2 byte) *Encoder { + return &Encoder{ + specialChar1: specialCh1, + specialChar2: specialCh2, + } +} + +// Encode the input string to MetaString using adaptive encoding +func (e *Encoder) Encode(input string) MetaString { + encoding := e.ComputeEncoding(input) + return e.EncodeWithEncoding(input, encoding) +} + +// EncodeWithEncoding Encodes the input string to MetaString using specified encoding. +func (e *Encoder) EncodeWithEncoding(input string, encoding Encoding) MetaString { + if len(input) > 32767 { + panic("Long meta string than 32767 is not allowed") Review Comment: Does it mean the `Encode` function signature should be changed to this: `func (e *Encoder) Encode(input string) (MetaString, error)`, because the error has to propagate to the caller ? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
