chaokunyang commented on code in PR #1612: URL: https://github.com/apache/incubator-fury/pull/1612#discussion_r1594139541
########## docs/specification/xlang_serialization_spec.md: ########## @@ -139,16 +139,17 @@ Fury will write the byte order for that object into the data instead of converti Fury header consists starts one byte: ``` -| 2 bytes | 4 bits | 1 bit | 1 bit | 1 bit | 1 bit | optional 4 bytes | -+--------------+---------------+-------+-------+--------+-------+------------------------------------+ -| magic number | reserved bits | oob | xlang | endian | null | unsigned int for meta start offset | +| 2 bytes | 4 bits | 1 bit | 1 bit | 1 bit | 1 bit | 1 byte | optional 4 bytes | ++--------------+---------------+-------+-------+--------+-------+--------------------------+------------------------------------+ +| magic number | reserved bits | oob | xlang | endian | null | serialization language | unsigned int for meta start offset | ``` - magic number: used to identify fury serialization protocol, current version use `0x62d4`. - null flag: 1 when object is null, 0 otherwise. If an object is null, other bits won't be set. - endian flag: 1 when data is encoded by little endian, 0 for big endian. - xlang flag: 1 when serialization uses xlang format, 0 when serialization uses Fury java format. - oob flag: 1 when passed `BufferCallback` is not null, 0 otherwise. +- serialization language: indicates the language used for serialization, such as JAVA, PYTHON, GO, etc. Review Comment: How about: ```suggestion - language: the language when serializing objects, such as JAVA, PYTHON, GO, etc. ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
