jasonmokk commented on code in PR #1620:
URL: https://github.com/apache/incubator-fury/pull/1620#discussion_r1596386171
##########
java/fury-core/src/main/java/org/apache/fury/meta/MetaStringEncoder.java:
##########
@@ -70,6 +70,9 @@ public MetaString encode(String input, Encoding[] encodings) {
public MetaString encode(String input, Encoding encoding) {
Preconditions.checkArgument(
input.length() < Short.MAX_VALUE, "Long meta string than 32767 is not
allowed");
+ if (encoding != Encoding.UTF_8 && !isASCII(input)) {
Review Comment:
Got it, PR has been updated. Thanks for the review!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
