MrChang0 commented on issue #1632: URL: https://github.com/apache/incubator-fury/issues/1632#issuecomment-2110245478
> > > If we remove it, those classes will never be collected. In some hot-loading classes scenarios, it will may cause class leak > > > > > > I see it could be just remain `weakKeys`, `softValues` will cause that fury must create again when after gc. > > The values can have strong references to keys. If value are not soft references, the weak key won't make the classes eligible for gc. If we remove soft values. The weak keys should be removed too I'd like think whether `softValue` or not will not effect `weakKeys`. `weakKeys` will take key reference as `WeakEntry`, and won't effected be valueReference. maybe we can take a test for it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
